r97877 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97876‎ | r97877 | r97878 >
Date:01:01, 23 September 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
fix for TestCanonicalRedirect hook
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
——@@ -201,7 +201,7 @@
202202
203203 public function testCanonicalRedirect( $request, $title, $output ) {
204204 $xDevice = isset( $_SERVER['HTTP_X_DEVICE'] ) ? $_SERVER['HTTP_X_DEVICE'] : '';
205 - return ( !empty( $xDevice ) );
 205+ return ( empty( $xDevice ) );
206206 }
207207
208208 public function addMobileFooter( &$obj, &$tpl ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97876fix for TestCanonicalRedirect hookpreilly01:00, 23 September 2011

Comments

#Comment by Brion VIBBER (talk | contribs)   01:07, 23 September 2011

Fixes the condition check in r97876; Patrick's about to commit a version that's more explicit so we don't get it wrong again. ;)

Status & tagging log