r97831 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97830‎ | r97831 | r97832 >
Date:17:50, 22 September 2011
Author:siebrand
Status:deferred (Comments)
Tags:
Comment:
Fix some i18n and L10n issues.
Modified paths:
  • /trunk/extensions/LinkFilter/LinkFilter.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LinkFilter/LinkFilter.i18n.php
@@ -39,8 +39,10 @@
4040 'linkfilter-home-button' => 'Links home',
4141 'linkfilter-submit-success-title' => 'Link submitted',
4242 'linkfilter-submit-success-text' => 'Your link has been sent for approval',
43 - 'linkfilter-instructions' => 'You can add some instructions for users [[MediaWiki:Linkfilter-instructions|here]]',
44 - 'linkfilter-admin-instructions' => 'You can add some instructions for admins [[MediaWiki:Linkfilter-admin-instructions|here]]',
 43+ 'linkfilter-instructions-url' => 'Linkfilter-instructions',
 44+ 'linkfilter-instructions' => 'You can [[{{MediaWiki:Linkfilter-instructions-url}}|add instructions for users]].',
 45+ 'linkfilter-admin-instructions-url' => 'Linkfilter-admin-instructions',
 46+ 'linkfilter-admin-instructions' => 'You can add [[{{MediaWiki:Linkfilter-admin-instructions-url}}|instructions for administrators]].',
4547 'linkfilter-admin-recent' => 'Recently approved',
4648 'linkfilter-approve-title' => 'Link administration',
4749 'linkfilter-submittedby' => 'Submitted by',
@@ -75,32 +77,14 @@
7678 'grouppage-linkadmin' => '{{ns:project}}:Link administrators',
7779 // For Special:ListGroupRights
7880 'right-linkadmin' => 'Administrate user-submitted links',
79 -/*
80 - 'linkfilter-instructions' => "==Ground Rules==
81 -1) If it's not safe for work, label it as \"NSFW\".
 81+);
8282
83 -2) Don't post the same link twice.
84 -
85 -3) No links to hate sites or private information.
86 -
87 -4) Make sure the links actually work, mmmkay?
88 -
89 -5) In general, use common sense.
90 -
91 -6) If you get banned for breaking these rules, don't whine about it. The ban may only be for a day or two, but even if it's longer, stfu.
92 -
93 -__NOTOC__
94 -__NOEDITSECTION__",
95 - 'linkfilter-admin-instructions' => "==Before you approve a link, remember the RULES==\n
96 -1) No porn. <br />
97 -2) No graphic content unless there's an NSFW warning. <br />
98 -3) Don't post hate speech. <br />
99 -4) Don't post broken images/links. <br />
100 -5) Don't post private/contact information no matter how easily obtained. <br />
101 -6) Don't post the same link more than once. <br />
102 -7) If some dude is spamming, don't post his links. One is OK.<br />
103 -8) If someone is submitting really good stuff, let me me know -- s/he'd probably make a good admin.<br />",
104 - */
 83+/** Message documentation
 84+ * @author Siebrand
 85+ */
 86+$messages['qqq'] = array(
 87+ 'linkfilter-instructions-url' => 'Page name for LinkFilter instructions. Use in content language in {{msg-mw|linkfilter-instructions}}.',
 88+ 'linkfilter-admin-instructions-url' => 'Page name for LinkFilter instructions for administrators. Use in content language in {{msg-mw|linkfilter-admin-instructions}}.',
10589 );
10690
10791 /** Finnish (Suomi)

Comments

#Comment by Jack Phoenix (talk | contribs)   18:30, 22 September 2011

I'm not seeing the point of this. It seems that this change adds complexity to the code without actually being useful. What's wrong with ordinary links?

#Comment by Siebrand (talk | contribs)   18:57, 22 September 2011

This ensures that users on a wiki are sent to a single page unrelated to their user language. Translators will (and should) be able to localise page names, which would lead to red links even though there might not be a need to display red links.

Status & tagging log