r97829 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97828‎ | r97829 | r97830 >
Date:17:27, 22 September 2011
Author:danny_b
Status:resolved (Comments)
Tags:
Comment:
* + XHTML necessities accidentally lost in r97778
Modified paths:
  • /trunk/tools/web-scripts/missing.php (modified) (history)

Diff [purge]

Index: trunk/tools/web-scripts/missing.php
——@@ -121,15 +121,17 @@
122122 header( 'Content-Type: text/html; charset=utf-8');
123123
124124 echo <<< EOT
125 -<html>
 125+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
126126
 127+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en" dir="ltr">
 128+
127129 <head>
128130
129131 <title>$language&nbsp;$project does not exist</title>
130132
131 -<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
 133+<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
132134
133 -<link rel="shortcut icon" href="$home/favicon.ico">
 135+<link rel="shortcut icon" href="$home/favicon.ico" />
134136
135137 <style type="text/css">
136138 /* <![CDATA[ */

Follow-up revisions

RevisionCommit summaryAuthorDate
r97834* fixing the sliced part of the arraydanny_b18:53, 22 September 2011
r106562* Remove unneeded whitespace...robin14:43, 18 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97778* Changing static page to dynamic result according to the given URL....danny_b01:25, 22 September 2011

Comments

#Comment by SPQRobin (talk | contribs)   17:36, 22 September 2011

Maybe we can do just <!DOCTYPE html> like it is in HTML5?

#Comment by 😂 (talk | contribs)   15:11, 16 December 2011

Agreed, we should fix up this page to be HTML5.

#Comment by Danny B. (talk | contribs)   18:25, 16 December 2011

I don't see any urgent need to do that - it doesn't hurt anything nor causes any issues. There are still lots of legacy browsers around which do not support HTML5, so why should we hurry, when there is no need?

#Comment by SPQRobin (talk | contribs)   14:46, 18 December 2011

MediaWiki uses by default HTML5. It's the other way around: no need to stick with old stuff. -> r106562

#Comment by Danny B. (talk | contribs)   14:57, 18 December 2011

However, this is not MediaWiki, but just server stuff.

Status & tagging log