r97707 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97706‎ | r97707 | r97708 >
Date:08:54, 21 September 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Added missing calls to SpecialPage::setHeaders() and SpecialPage::outputHeader()
Modified paths:
  • /trunk/phase3/includes/specials/SpecialBlock.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialEditWatchlist.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialTags.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUnblock.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUnblock.php
@@ -49,6 +49,9 @@
5050 list( $this->target, $this->type ) = SpecialBlock::getTargetAndType( $par, $this->getRequest() );
5151 $this->block = Block::newFromTarget( $this->target );
5252
 53+ $this->setHeaders();
 54+ $this->outputHeader();
 55+
5356 $out = $this->getOutput();
5457 $out->setPageTitle( wfMsg( 'unblockip' ) );
5558 $out->addModules( 'mediawiki.special' );
Index: trunk/phase3/includes/specials/SpecialEditWatchlist.php
@@ -32,6 +32,8 @@
3333 throw new ReadOnlyError;
3434 }
3535
 36+ $this->setHeaders();
 37+
3638 $out = $this->getOutput();
3739
3840 # Anons don't get a watchlist
@@ -47,6 +49,8 @@
4850 return;
4951 }
5052
 53+ $this->outputHeader();
 54+
5155 $sub = wfMsgExt(
5256 'watchlistfor2',
5357 array( 'parseinline', 'replaceafter' ),
Index: trunk/phase3/includes/specials/SpecialBlock.php
@@ -87,6 +87,9 @@
8888 throw new ErrorPageError( 'badaccess', $status );
8989 }
9090
 91+ $this->setHeaders();
 92+ $this->outputHeader();
 93+
9194 $out = $this->getOutput();
9295 $out->setPageTitle( wfMsg( 'blockip-title' ) );
9396 $out->addModules( 'mediawiki.special', 'mediawiki.special.block' );
Index: trunk/phase3/includes/specials/SpecialTags.php
@@ -36,6 +36,9 @@
3737 }
3838
3939 function execute( $par ) {
 40+ $this->setHeaders();
 41+ $this->outputHeader();
 42+
4043 $out = $this->getOutput();
4144 $out->setPageTitle( wfMsg( 'tags-title' ) );
4245 $out->wrapWikiMsg( "<div class='mw-tags-intro'>\n$1\n</div>", 'tags-intro' );

Comments

#Comment by Nikerabbit (talk | contribs)   09:46, 21 September 2011

Can you tell what was the symptom of missing calls?

Status & tagging log