r97704 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97703‎ | r97704 | r97705 >
Date:08:39, 21 September 2011
Author:aaron
Status:resolved (Comments)
Tags:
Comment:
Tweaked diff size number location to make sp:contribs look prettier and more consistent with how it was without them
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -703,7 +703,7 @@
704704 }
705705
706706 $diffHistLinks = '(' . $difftext . $this->messages['pipe-separator'] . $histlink . ')';
707 - $ret = "{$del}{$d} {$diffHistLinks} {$nflag}{$mflag}{$chardiff} {$link}{$userlink} {$comment} {$topmarktext}";
 707+ $ret = "{$del}{$d} {$diffHistLinks}{$chardiff}{$nflag}{$mflag} {$link}{$userlink} {$comment} {$topmarktext}";
708708
709709 # Denote if username is redacted for this edit
710710 if( $rev->isDeleted( Revision::DELETED_USER ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r97706FU 97704: I was thinking the space was already added in this caseaaron08:52, 21 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:49, 21 September 2011

Causes missing space between histlinks and flags if no chardiff. I also don't see how this improves anything.

Status & tagging log