r97578 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97577‎ | r97578 | r97579 >
Date:23:41, 19 September 2011
Author:wikinaut
Status:resolved (Comments)
Tags:
Comment:
follow up to r97566 - adding message documentation for new message texts (identical to two prefs- texts)
Modified paths:
  • /trunk/extensions/OpenID/OpenID.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenID/OpenID.i18n.php
——@@ -196,7 +196,9 @@
197197 'openid-pref-hide' => 'OpenID preference label (Hide your OpenID URL on your user page, if you log in with OpenID)',
198198 'openid-pref-update-userinfo-on-login' => 'OpenID preference label for updating fron OpenID persona upon login',
199199 'openid-urls-action' => '{{Identical|Action}}',
200 - 'openid-urls-delete' => '{{identical|Delete}}',
 200+ 'openid-urls-delete' => '{{Identical|Delete}}',
 201+ 'openid-urls-registration' => '{{Identical|prefs-registration}}',
 202+ 'openid-urls-registration-date-time' => '{{Identical|prefs-registration-date-time}}',
201203 'specialpages-group-openid' => 'Display group name for OpenID-extension related special pages for Special:SpecialPages',
202204 'right-openid-dashboard-access' => 'the standard access right for the OpenID dashboard, which is a restricted special page',
203205 'right-openid-dashboard-admin' => 'the special adminstrator access right for the OpenID dashboard, which is a restricted special page',

Follow-up revisions

RevisionCommit summaryAuthorDate
r97799fixes and follow up to r97578 . fixes message texts which are used in in same...wikinaut06:43, 22 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97566follow up to r97447 : show OpenID registration timestamps in OpenID preferenc...wikinaut22:18, 19 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   11:18, 21 September 2011

Some words about the context would also be useful.

There are no identical templates for prefs-registration and prefs-registration-date-time.

#Comment by Wikinaut (talk | contribs)   22:32, 21 September 2011

Context? see r97566: show OpenID registration timestamps in OpenID preference tab, if these are present. it is exactly like the standard login: the timestamp of registration time is shown.

That is, why I use exactly the same coding and text like in SpecialPreferences.php .

No need to fix anything.

#Comment by Nikerabbit (talk | contribs)   04:53, 22 September 2011

Let me clarify. You can just use {{Identical|some message key}}, because the parameter refers to a template. A list of available identical templates is in link below. If you want to state that the message is used in in same way as some other message, say "This message is used in the same way as {{msg-mw|some message key}}".

#Comment by Wikinaut (talk | contribs)   06:44, 22 September 2011

fixed in r97799 !

I changed s/Indentical/msg-mw/ in _all_ messages of OpenID extension see r97799 .

Please can you (Nikerabbit) document the differences in use between

  • {{Identical|this}} and
  • msg-mw

on the MediaWiki page

#Comment by Wikinaut (talk | contribs)   06:45, 22 September 2011

See here r1=97798&r2=97799 http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/OpenID/OpenID.i18n.php?&pathrev=97799&r1=97798&r2=97799 all changes

Status & tagging log