r97564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97563‎ | r97564 | r97565 >
Date:21:55, 19 September 2011
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Removed duplication in insertArticleLink
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -304,21 +304,14 @@
305305 $params['rcid'] = $rc->mAttribs['rc_id'];
306306 }
307307
 308+ $articlelink = Linker::linkKnown(
 309+ $rc->getTitle(),
 310+ null,
 311+ array(),
 312+ $params
 313+ );
308314 if( $this->isDeleted($rc,Revision::DELETED_TEXT) ) {
309 - $articlelink = Linker::linkKnown(
310 - $rc->getTitle(),
311 - null,
312 - array(),
313 - $params
314 - );
315315 $articlelink = '<span class="history-deleted">' . $articlelink . '</span>';
316 - } else {
317 - $articlelink = ' '. Linker::linkKnown(
318 - $rc->getTitle(),
319 - null,
320 - array(),
321 - $params
322 - );
323316 }
324317 # Bolden pages watched by this user
325318 if( $watched ) {

Comments

#Comment by Nikerabbit (talk | contribs)   06:36, 20 September 2011

How about the space?

#Comment by Aaron Schulz (talk | contribs)   00:29, 11 November 2011

I don't think it's needed.

Status & tagging log