r97560 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97559‎ | r97560 | r97561 >
Date:21:24, 19 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix strict errors
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -90,7 +90,7 @@
9191 $wgLDAPUseFetchedUsername = array();
9292 $wgPasswordResetRoutes['domain'] = true;
9393
94 -define( "LDAPAUTHVERSION", "1.2g" );
 94+define( "LDAPAUTHVERSION", "1.2h" );
9595
9696 /**
9797 * Add extension information to Special:Version
@@ -440,7 +440,7 @@
441441 * @param UserLoginTemplate $template
442442 * @access public
443443 */
444 - function modifyUITemplate( &$template ) {
 444+ function modifyUITemplate( &$template, &$type ) {
445445 global $wgLDAPAddLDAPUsers;
446446 global $wgLDAPMailPassword;
447447
@@ -508,7 +508,7 @@
509509 * @return bool
510510 * @access public
511511 */
512 - function setPassword( $user, &$password ) {
 512+ function setPassword( $user, $password ) {
513513 global $wgLDAPUpdateLDAP, $wgLDAPWriterDN, $wgLDAPWriterPassword;
514514
515515 $this->printDebug( "Entering setPassword", NONSENSITIVE );
@@ -691,7 +691,7 @@
692692 * @return bool
693693 * @access public
694694 */
695 - function addUser( $user, $password ) {
 695+ function addUser( $user, $password, $email = '', $realname = '' ) {
696696 global $wgLDAPAddLDAPUsers, $wgLDAPWriterDN, $wgLDAPWriterPassword;
697697 global $wgLDAPSearchAttributes;
698698 global $wgLDAPWriteLocation;
@@ -913,7 +913,7 @@
914914 * @access public
915915 * TODO: fix setExternalID stuff
916916 */
917 - function initUser( &$user ) {
 917+ function initUser( &$user, $autocreate = false ) {
918918 $this->printDebug( "Entering initUser", NONSENSITIVE );
919919
920920 if ( $this->authFailed ) {

Status & tagging log