r97559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97558‎ | r97559 | r97560 >
Date:21:18, 19 September 2011
Author:brion
Status:ok
Tags:
Comment:
MFT r97558: fix/eliminate bug 30977 and restore Special:FilePath's input validation to 2008 borders
Modified paths:
  • /branches/REL1_18/phase3/includes/specials/SpecialFilepath.php (modified) (history)
  • /branches/REL1_18/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/includes/specials/SpecialFilepath.php
@@ -40,7 +40,7 @@
4141
4242 $file = !is_null( $par ) ? $par : $wgRequest->getText( 'file' );
4343
44 - $title = Title::makeTitleSafe( NS_FILE, $file );
 44+ $title = Title::newFromText( $file, NS_FILE );
4545
4646 if ( ! $title instanceof Title || $title->getNamespace() != NS_FILE ) {
4747 $this->showForm( $title );
Index: branches/REL1_18/phase3/languages/messages/MessagesEn.php
@@ -4490,10 +4490,8 @@
44914491 'filepath-page' => 'File:',
44924492 'filepath-submit' => 'Go',
44934493 'filepath-summary' => 'This special page returns the complete path for a file.
4494 -Images are shown in full resolution, other file types are started with their associated program directly.
 4494+Images are shown in full resolution, other file types are started with their associated program directly.',
44954495
4496 -Enter the file name without the "{{ns:file}}:" prefix.',
4497 -
44984496 # Special:FileDuplicateSearch
44994497 'fileduplicatesearch' => 'Search for duplicate files',
45004498 'fileduplicatesearch-summary' => 'Search for duplicate files based on hash values.',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97558* (bug 30977) Remove directions cruft, undo random limitation of input format...brion21:16, 19 September 2011

Status & tagging log