r97469 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97468‎ | r97469 | r97470 >
Date:11:31, 19 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix typo from r97461, was breaking unit tests
Modified paths:
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/Language.php
@@ -438,7 +438,7 @@
439439 return false;
440440 } else {
441441 // Check what is in i18n files
442 - $alises = self::$dataCache->getItem( $this->mCode, 'namespaceGenderAliases' );
 442+ $aliases = self::$dataCache->getItem( $this->mCode, 'namespaceGenderAliases' );
443443 return count( $aliases ) > 0;
444444 }
445445 }
@@ -475,6 +475,7 @@
476476 }
477477 }
478478
 479+ // <Nikerabbit> make $wgExtraNamespaces take precedence over $namespaceGenderAliases when $wgExtraGenderNamespaces are not defined
479480 global $wgExtraGenderNamespaces;
480481 $genders = $wgExtraGenderNamespaces + self::$dataCache->getItem( $this->mCode, 'namespaceGenderAliases' );
481482 foreach ( $genders as $index => $forms ) {
@@ -535,12 +536,12 @@
536537 * short names for language variants used for language conversion links.
537538 *
538539 * @param $code String
539 - * @param $usemsg Use the "variantname-xyz" message if it exists
 540+ * @param $usemsg bool Use the "variantname-xyz" message if it exists
540541 * @return string
541542 */
542543 function getVariantname( $code, $usemsg = true ) {
543544 $msg = "variantname-$code";
544 - $codeArray = list( $rootCode ) = explode( '-', $code );
 545+ list( $rootCode ) = explode( '-', $code );
545546 if( $usemsg && wfMessage( $msg )->exists() ) {
546547 return $this->getMessageFromDB( $msg );
547548 } elseif( $name = self::getLanguageName( $code ) ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r97470Remove comment from r97469reedy11:33, 19 September 2011
r97481REL1_18 MFT r97460, r97461, r97469, r97470, r97475reedy12:58, 19 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97461* (bug 27398) Add $wgExtraGenderNamespaces for configured gendered namespacesnikerabbit10:43, 19 September 2011

Status & tagging log