r97415 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97414‎ | r97415 | r97416 >
Date:12:39, 18 September 2011
Author:nikerabbit
Status:ok (Comments)
Tags:
Comment:
Address one issue in r94138. Also added caller to linkbatch for debugging
Modified paths:
  • /trunk/extensions/Babel/Babel.class.php (modified) (history)
  • /trunk/extensions/Babel/BabelStatic.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Babel/Babel.class.php
@@ -25,6 +25,8 @@
2626
2727 self::mTemplateLinkBatch( $parameters );
2828
 29+ $parser->getOutput()->addModuleStyles( 'ext.babel' );
 30+
2931 $content = '';
3032 $templateParameter[0] = '' ; // collects name=value parameters to be passed to wiki templates.
3133 foreach ( $parameters as $name ) {
@@ -106,6 +108,7 @@
107109 }
108110
109111 $batch = new LinkBatch( $titles );
 112+ $batch->setCaller( __METHOD__ );
110113 $batch->execute();
111114 }
112115
Index: trunk/extensions/Babel/BabelStatic.class.php
@@ -14,8 +14,6 @@
1515 * @return Boolean: True.
1616 */
1717 public static function Setup( $parser ) {
18 - global $wgOut;
19 - $wgOut->addModuleStyles( 'ext.babel' );
2018 $parser->setFunctionHook( 'babel', array( 'Babel', 'Render' ) );
2119 return true;
2220 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94138* Use ResourceLoader for Babel extension (Babel::Render() is a more logical p...robin21:51, 9 August 2011

Comments

#Comment by SPQRobin (talk | contribs)   13:05, 18 September 2011

Thanks

Status & tagging log