r97377 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97376‎ | r97377 | r97378 >
Date:15:50, 17 September 2011
Author:catrope
Status:ok
Tags:
Comment:
Followup r95562: forgot to convert one case. Thanks to Nikerabbit for providing the line number
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1131,8 +1131,10 @@
11321132 {
11331133 if ( md5( $this->summary ) == $this->autoSumm ) {
11341134 $this->missingSummary = true;
 1135+ $status->fatal( 'missingsummary' );
 1136+ $status->value = self::AS_SUMMARY_NEEDED;
11351137 wfProfileOut( __METHOD__ );
1136 - return self::AS_SUMMARY_NEEDED;
 1138+ return $status;
11371139 }
11381140 }
11391141

Follow-up revisions

RevisionCommit summaryAuthorDate
r97458REL1_18 MFT r97377reedy08:07, 19 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95562(bug 29246) Edit API occasionally throws "unknown error 231". Per comment #1 ...catrope16:26, 26 August 2011

Status & tagging log