r97364 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97363‎ | r97364 | r97365 >
Date:02:37, 17 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] ReferenceError: id not defined. Fix copy-paste failure from r97154 (see CR)
Modified paths:
  • /branches/RL2/extensions/Gadgets/modules/ext.gadgets.api.js (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/modules/ext.gadgets.api.js
@@ -299,7 +299,7 @@
300300 dataType: 'json',
301301 success: function( data ) {
302302 // Invalidate cache
303 - cacheGadgetData( 'local', id, null );
 303+ cacheGadgetData( 'local', gadget.id, null );
304304 if ( data && data.edit && data.edit ) {
305305 if ( data.edit.result === 'Success' ) {
306306 o.success( data.edit );
@@ -314,7 +314,7 @@
315315 },
316316 error: function(){
317317 // Invalidate cache
318 - cacheGadgetData( 'local', id, null );
 318+ cacheGadgetData( 'local', gadget.id, null );
319319 o.error( 'unknown' );
320320 }
321321 });

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97154RL2: Rewrite of ext.gadgets.api that Timo and I worked on together at http://......catrope14:17, 15 September 2011

Status & tagging log