r97363 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97362‎ | r97363 | r97364 >
Date:02:34, 17 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
[RL2] More renaming from 'name' to 'id'
(Follows-up r96761, r97354)
Modified paths:
  • /branches/RL2/extensions/Gadgets/GadgetHooks.php (modified) (history)

Diff [purge]

Index: branches/RL2/extensions/Gadgets/GadgetHooks.php
@@ -20,7 +20,7 @@
2121 */
2222 public static function getIDFromTitle( Title $title ) {
2323 $id = $title->getText();
24 - if ( $title->getNamespace() !== NS_GADGET_DEFINITION || !preg_match( '!\.js$!u', $name ) ) {
 24+ if ( $title->getNamespace() !== NS_GADGET_DEFINITION || !preg_match( '!\.js$!u', $id ) ) {
2525 // Not a gadget definition page
2626 return null;
2727 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96761[ResourceLoader2] (BREAKING CHANGE) Rename gd_name to gd_id to avoid confusio...krinkle00:08, 11 September 2011
r97354[RL2] More renaming from 'name' to 'id'...krinkle01:32, 17 September 2011

Status & tagging log