r97335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97334‎ | r97335 | r97336 >
Date:21:08, 16 September 2011
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Forgot to press Ctrl-S: r97334 (was: Per initial commit r96356)
Modified paths:
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)
  • /trunk/extensions/skins/Nimbus/Nimbus.i18n.php (modified) (history)
  • /trunk/extensions/skins/Nimbus/Nimbus.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
——@@ -900,6 +900,7 @@
901901 New Users List
902902
903903 Nimbus
 904+file = skins/Nimbus/Nimbus.i18n.php
904905 ignored = morewikis, nimbus-advertise-url
905906
906907 Notificator
Index: trunk/extensions/skins/Nimbus/Nimbus.i18n.php
——@@ -9,6 +9,7 @@
1010 /** English */
1111 $messages['en'] = array(
1212 'morewikis' => '', // format for this message is *Page name/Interwiki link/URL|Text to show
 13+ 'nimbus-desc' => 'Nimbus skin for MediaWiki',
1314 'nimbus-advertise' => 'Advertise',
1415 'nimbus-advertise-url' => '', // set this to an URL if you want an "Advertise" link to show up in the footer
1516 'nimbus-contribute' => 'Contribute',
Index: trunk/extensions/skins/Nimbus/Nimbus.php
——@@ -27,7 +27,7 @@
2828 'name' => 'Nimbus',
2929 'version' => '2.0',
3030 'author' => array( 'Aaron Wright', 'David Pean', 'Inez Korczyński', 'Jack Phoenix' ),
31 - 'description' => 'Nimbus skin for MediaWiki',
 31+ 'descriptionmsg' => 'nimbus-desc',
3232 'url' => 'http://www.mediawiki.org/wiki/Nimbus_skin',
3333 );
3434

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96356Nimbus -- the skin used on Halopedia (http://www.halopedian.com/). Tested aga...ashley18:09, 6 September 2011
r97334Per initial commit r96356: Some tweaks to the i18n file: Uppercase -> lowerca...raymond21:03, 16 September 2011

Comments

#Comment by Jack Phoenix (talk | contribs)   09:02, 17 September 2011

This is awfully silly. :)
On top of the fact that I'm no big fan of descriptionmsg stuff, the description used here is more like a placeholder rather than anything worth translating. If you can come up with a better, more useful description, by all means change the text! I'm just rather convinced that it's not worth anyone's time to translate "Nimbus skin for MediaWiki" into different languages, as it doesn't really tell much; it tells that it's a MediaWiki skin, its name is Nimbus and...that's it.

Extension:MWSearch (which is used on Wikimedia sites) has an equally useful description message, which has been translated into various languages, though it seems that some translations, such as Bavarian (Boarisch; language code bar) and German (Deutsch; language code de) are more useful than the English source text.

#Comment by Raymond (talk | contribs)   20:54, 17 September 2011

I really do not understand your resistance against description messages, as well as for simple parser extensions. A translated desc message is a valuable information for the non english speaking user.

Status & tagging log