r97305 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97304‎ | r97305 | r97306 >
Date:18:18, 16 September 2011
Author:preilly
Status:ok (Comments)
Tags:
Comment:
add a version to js to bust cache
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/application.html.php
——@@ -34,7 +34,7 @@
3535 }
3636 //]]>
3737 </script>
38 - <script type="text/javascript" language="javascript" src="{$wgExtensionAssetsPath}/MobileFrontend/javascripts/application.js"></script>
 38+ <script type="text/javascript" language="javascript" src="{$wgExtensionAssetsPath}/MobileFrontend/javascripts/application.js?version=20110912T172820Z"></script>
3939 </head>
4040 <body>
4141 {$searchWebkitHtml}

Follow-up revisions

RevisionCommit summaryAuthorDate
r97306mft r97305preilly18:19, 16 September 2011

Comments

#Comment by Hashar (talk | contribs)   11:31, 25 November 2011

The only bad thing is that you might be forgetting to update the version number when editing the .js file :)

You might use a global variable to easily update that version number in all your code. Much like http://www.mediawiki.org/wiki/Manual:$wgStyleVersion in core.

Status & tagging log