r97241 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97240‎ | r97241 | r97242 >
Date:06:23, 16 September 2011
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Fix typo
Modified paths:
  • /branches/lqt-updates/extensions/LiquidThreads/classes/view/PostToolbar.php (modified) (history)

Diff [purge]

Index: branches/lqt-updates/extensions/LiquidThreads/classes/view/PostToolbar.php
——@@ -169,10 +169,10 @@
170170 $version = $context->get('version');
171171
172172 // TODO make this link operate properly
173 - $history_url = SpecialPage::getTitleFor( 'PostHistory', $post->getID() );
 173+ $history = SpecialPage::getTitleFor( 'PostHistory', $post->getID() );
174174 $commands['history'] = array(
175175 'label' => wfMsgExt( 'history_short', 'parseinline' ),
176 - 'href' => $history_url,
 176+ 'href' => $history->getFullURL(),
177177 'enabled' => true,
178178 );
179179

Comments

#Comment by Nikerabbit (talk | contribs)   06:27, 16 September 2011

Any particular reason to use fullURL instead of localURL?

#Comment by Werdna (talk | contribs)   06:31, 16 September 2011

Not really, is there a preference for the latter? I guess it works better for different domains etc…

#Comment by Nikerabbit (talk | contribs)   07:23, 16 September 2011

Latter does not have problems with choosing the correct protocol :)

#Comment by Catrope (talk | contribs)   09:27, 16 September 2011

How does getFullURL() have protocol choosing issues? It'll just use the protocol from $wgServer (which might mean none, if $wgServer is protocol-relative).

Status & tagging log