r97238 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97237‎ | r97238 | r97239 >
Date:06:13, 16 September 2011
Author:hashar
Status:ok
Tags:
Comment:
revert r97203

That code was not really meant to work :-D
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1303,19 +1303,10 @@
13041304 in the message (bool)
13051305
13061306 'OldChangesListRecentChangesLine': Customize entire Recent Changes line.
1307 -you will also need to use the EnhancedChangesListRecentChangesLine to alter
1308 -the output for user of enhanced recent changes.
13091307 &$changeslist: The OldChangesList instance.
13101308 &$s: HTML of the form "<li>...</li>" containing one RC entry.
13111309 &$rc: The RecentChange object.
13121310
1313 -'RecentChangesListRecentChangesLine': Customize entire Recent Changes line.
1314 -you will also need to use the OldChangesListRecentChangesLine to alter
1315 -the output for user of regular recent changes.
1316 -&$changeslist: The EnhancedChangesList instance.
1317 -&$s: HTML of the form "<li>...</li>" containing one RC entry.
1318 -&$rc: The RecentChange object.
1319 -
13201311 'OpenSearchUrls': Called when constructing the OpenSearch description XML.
13211312 Hooks can alter or append to the array of URLs for search & suggestion formats.
13221313 &$urls: array of associative arrays with Url element attributes
Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -61,9 +61,6 @@
6262 to stop it from replace an already existing default sort, and suppress error.
6363 * (bug 18578) Rewrote revision delete related messages to allow better
6464 localisation
65 -* New hook RecentChangesListRecentChangesLine which let you customize an
66 - entire recent changes line for user with 'Enhanced recent changes' option
67 - It is equivalent to the existing hook OldChangesListRecentChangesLine
6865
6966 === Bug fixes in 1.19 ===
7067 * $wgUploadNavigationUrl should be used for file redlinks if
Index: trunk/phase3/includes/ChangesList.php
@@ -741,8 +741,6 @@
742742 array_push( $this->rc_cache[$secureName], $rc );
743743 }
744744
745 - wfRunHooks( 'EnhancedChangesListRecentChangesLine', array(&$this, &$s, $rc) );
746 -
747745 wfProfileOut( __METHOD__ );
748746
749747 return $ret;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r97203New hook RecentChangesListRecentChangesLine which let you customize an...hashar20:57, 15 September 2011

Status & tagging log