r97192 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97191‎ | r97192 | r97193 >
Date:19:07, 15 September 2011
Author:robin
Status:ok
Tags:
Comment:
Use wfSpecialList() so it displays properly when user direction != content direction, and call Linker function statically.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialCategories.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialCategories.php
@@ -120,10 +120,10 @@
121121 function formatRow($result) {
122122 global $wgLang;
123123 $title = Title::makeTitle( NS_CATEGORY, $result->cat_title );
124 - $titleText = $this->getSkin()->link( $title, htmlspecialchars( $title->getText() ) );
 124+ $titleText = Linker::link( $title, htmlspecialchars( $title->getText() ) );
125125 $count = wfMsgExt( 'nmembers', array( 'parsemag', 'escape' ),
126126 $wgLang->formatNum( $result->cat_pages ) );
127 - return Xml::tags('li', null, "$titleText ($count)" ) . "\n";
 127+ return Xml::tags('li', null, wfSpecialList( $titleText, $count ) ) . "\n";
128128 }
129129
130130 public function getStartForm( $from ) {

Sign-offs

UserFlagDate
Nikerabbitinspected04:53, 16 September 2011
Nikerabbittested04:53, 16 September 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r97276REL1_18 MFT r97144, r97146, r97192reedy14:41, 16 September 2011

Status & tagging log