r97151 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97150‎ | r97151 | r97152 >
Date:13:47, 15 September 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
(bug 30907) Special:Unusedcategories should sort ascendingly (A-Z not Z-A).
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUnusedcategories.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -91,6 +91,7 @@
9292 importing a new revision into it
9393 * Allowing moving the associated talk pages of subpages even if the base page
9494 has no subpage.
 95+* (bug 30907) Special:Unusedcategories should sort ascendingly.
9596
9697 === API changes in 1.19 ===
9798 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
Index: trunk/phase3/includes/specials/SpecialUnusedcategories.php
@@ -50,6 +50,13 @@
5151 );
5252 }
5353
 54+ /**
 55+ * A should come before Z (bug 30907)
 56+ */
 57+ function sortDescending() {
 58+ return false;
 59+ }
 60+
5461 function formatResult( $skin, $result ) {
5562 $title = Title::makeTitle( NS_CATEGORY, $result->title );
5663 return $skin->link( $title, $title->getText() );

Follow-up revisions

RevisionCommit summaryAuthorDate
r97173Merged revisions 97087,97091-97092,97094,97096-97098,97100-97101,97103,97136,...dantman16:19, 15 September 2011
r97197MFT to REL1_17...hashar20:22, 15 September 2011
r97198MFT to REL1_18...hashar20:25, 15 September 2011
r102387clean RN 1.19 of bugs merged in 1.18...hashar10:54, 8 November 2011

Comments

#Comment by Hashar (talk | contribs)   15:54, 15 September 2011

does it need a backport to 1.17 and 1.18 ?

#Comment by Bawolff (talk | contribs)   19:57, 15 September 2011

It could. Its such a minor thing I don't think it matters that much. It's been here since r10033 and it took this long for someone to report it.

#Comment by Hashar (talk | contribs)   20:26, 15 September 2011

Merged back to stables: 1.17.1 : r97197 1.18.0 : r97198

Status & tagging log