r97042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r97041‎ | r97042 | r97043 >
Date:08:32, 14 September 2011
Author:nikerabbit
Status:reverted (Comments)
Tags:
Comment:
Chrome seems to already support dir=auto, and I see no downsides using it for user comments.
Amir said that it is good.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
——@@ -1370,7 +1370,7 @@
13711371 return '';
13721372 } else {
13731373 $formatted = self::formatComment( $comment, $title, $local );
1374 - return " <span class=\"comment\">($formatted)</span>";
 1374+ return " <span class=\"comment\" dir=\"auto\">($formatted)</span>";
13751375 }
13761376 }
13771377

Follow-up revisions

RevisionCommit summaryAuthorDate
r111798Revert r97042, causes bug 34432werdna22:15, 17 February 2012

Comments

#Comment by Hashar (talk | contribs)   16:17, 17 October 2011

"auto" is only supported with HTML5. Maybe we should only add it with $wgHtml5 although browsers will probably just discard it as an invalid value.

#Comment by Nikerabbit (talk | contribs)   16:23, 17 October 2011

As far as I know it is harmless to browsers that don't understand it and no further action is required.

#Comment by Hashar (talk | contribs)   08:09, 18 October 2011

One possible issue would be a browser not understanding "auto" and falling back to LTR. Would be a minor issue though.

Validating :D

#Comment by Werdna (talk | contribs)   21:48, 17 February 2012

Causes bug 34432 in Chrome

#Comment by Werdna (talk | contribs)   22:16, 17 February 2012

Reverted in r111798.

Status & tagging log