r97036 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97035‎ | r97036 | r97037 >
Date:03:31, 14 September 2011
Author:demon
Status:ok (Comments)
Tags:
Comment:
Partial revert r97035, followup r96930: make recentchanges tests pass again
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/specials/SpecialRecentchangesTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/specials/SpecialRecentchangesTest.php
@@ -85,7 +85,7 @@
8686 array( # expected
8787 #0 => "rc_timestamp >= '20110223000000'",
8888 'rc_bot' => 0,
89 - 1 => sprintf( "rc_namespace IN ('%s','%s')", $ns1, $ns2 ),
 89+ 1 => sprintf( "(rc_namespace = '%s' OR rc_namespace = '%s')", $ns1, $ns2 ),
9090 ),
9191 array(
9292 'namespace' => $ns1,
@@ -104,7 +104,7 @@
105105 array( # expected
106106 #0 => "rc_timestamp >= '20110223000000'",
107107 'rc_bot' => 0,
108 - 1 => sprintf( "rc_namespace NOT IN ('%s','%s')", $ns1, $ns2 ),
 108+ 1 => sprintf( "(rc_namespace != '%s' AND rc_namespace != '%s')", $ns1, $ns2 ),
109109 ),
110110 array(
111111 'namespace' => $ns1,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96930Revert r87992 and followups r87998, r89028 (Support abstraction for 'NOT IN' ...demon00:19, 13 September 2011
r97035Renaming SpecialRecentchangesTest file to match conventions...krinkle01:37, 14 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:21, 14 September 2011

How does this revert r97035? Are the revisions mixed?

#Comment by 😂 (talk | contribs)   13:36, 14 September 2011

I meant r94244, copy+pasted the wrong rev :)

Status & tagging log