r97001 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r97000‎ | r97001 | r97002 >
Date:21:02, 13 September 2011
Author:brion
Status:ok
Tags:
Comment:
* (bug 26380) Add support for \widetilde to <math>

Reapplied r86965 (patch by Thenub314), plus parser test case to ensure that \widetilde{x} actually renders. (While we can't compare the contents of the image, the output hash will remain stable in the img url. Forcing $wgMathPath to a fixed fake path for parsertests.
Modified paths:
  • /trunk/extensions/Math/math/texutil.ml (modified) (history)
  • /trunk/extensions/Math/mathParserTests.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/Math/mathParserTests.txt
@@ -39,3 +39,14 @@
4040 #</p>
4141 #!! end
4242
 43+!! test
 44+BUG 26380: Add \widetilde support to match \widehat
 45+!! input
 46+<math>\widehat{x}</math>
 47+<math>\widetilde{x}</math>
 48+!! result
 49+<p><img class="tex" alt="\widehat{x}" src="/images/math/9/9/8/998309e831dfb051f233c92b4b8a825b.png" />
 50+<img class="tex" alt="\widetilde{x}" src="/images/math/e/9/e/e9e91996778a6d6f5cdf4cc951955206.png" />
 51+</p>
 52+!! end
 53+
Index: trunk/extensions/Math/math/texutil.ml
@@ -492,6 +492,7 @@
493493 | "\\hat" -> FUN_AR1 "\\hat "
494494 | "\\hline" -> LITERAL (TEX_ONLY "\\hline ")
495495 | "\\vline" -> LITERAL (TEX_ONLY "\\vline ")
 496+ | "\\widetilde" -> LITERAL (TEX_ONLY "\\widetilde ")
496497 | "\\widehat" -> LITERAL (TEX_ONLY "\\widehat ")
497498 | "\\overline" -> LITERAL (TEX_ONLY "\\overline ")
498499 | "\\overbrace" -> LITERAL (TEX_ONLY "\\overbrace ")

Follow-up revisions

RevisionCommit summaryAuthorDate
r97002Followup r97001: fix for Math parser tests image URLs...brion21:03, 13 September 2011
r97259REL1_18 MFT r97001, r97002, r97007, r97014, r97018, r97034reedy13:06, 16 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r86965This change adds support for the \widetilde command as mentioned in bug 26380thenub31418:44, 26 April 2011
r96990Revert changes to texvc that provide no test cases or examples of what they'r...brion19:00, 13 September 2011

Status & tagging log