r96811 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96810‎ | r96811 | r96812 >
Date:20:44, 11 September 2011
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Pass the context to the HTMLForm object
Modified paths:
  • /trunk/phase3/includes/specials/SpecialEmailuser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialEmailuser.php
——@@ -123,7 +123,7 @@
124124
125125 $this->mTargetObj = $ret;
126126
127 - $form = new HTMLForm( $this->getFormFields() );
 127+ $form = new HTMLForm( $this->getFormFields(), $this->getContext() );
128128 $form->addPreText( wfMsgExt( 'emailpagetext', 'parseinline' ) );
129129 $form->setSubmitText( wfMsg( 'emailsend' ) );
130130 $form->setTitle( $this->getTitle() );

Comments

#Comment by Nikerabbit (talk | contribs)   07:39, 12 September 2011 
         * @param $context RequestContext available since 1.18, will become compulsory in 1.18.
         *     Obviates the need to call $form->setTitle()

Someone has had grand plans :)

Status & tagging log