r96770 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96769‎ | r96770 | r96771 >
Date:04:07, 11 September 2011
Author:aaron
Status:ok
Tags:
Comment:
Fixed use of obsolete $action global var (bug 30851)
Modified paths:
  • /trunk/extensions/ConfirmAccount/RequestAccount_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ConfirmAccount/RequestAccount_body.php
@@ -12,7 +12,7 @@
1313 }
1414
1515 function execute( $par ) {
16 - global $wgUser, $wgOut, $wgRequest, $action, $wgUseRealNamesOnly,
 16+ global $wgUser, $wgOut, $wgRequest, $wgUseRealNamesOnly,
1717 $wgAccountRequestToS, $wgAccountRequestExtraInfo, $wgAccountRequestTypes;
1818 # If a user cannot make accounts, don't let them request them either
1919 global $wgAccountRequestWhileBlocked;
@@ -66,6 +66,7 @@
6767
6868 $this->skin = $wgUser->getSkin();
6969
 70+ $action = $wgRequest->getVal( 'action' );
7071 if ( $wgRequest->wasPosted() && $wgUser->matchEditToken( $wgRequest->getVal( 'wpEditToken' ) ) ) {
7172 $this->mPrevAttachment = $this->mPrevAttachment ? $this->mPrevAttachment : $this->mSrcName;
7273 $this->doSubmit();

Sign-offs

UserFlagDate
Nikerabbitinspected10:11, 11 September 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r96883MFT r96770aaron18:49, 12 September 2011

Status & tagging log