r96643 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96642‎ | r96643 | r96644 >
Date:02:13, 9 September 2011
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
Some of the english translations for our exif-orientation-X messages were wrong (CW instead of CCW, vice versa).

Do these types of changes need release-notes?
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesQqq.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3982,9 +3982,9 @@
39833983 'exif-orientation-3' => 'Rotated 180°',
39843984 'exif-orientation-4' => 'Flipped vertically',
39853985 'exif-orientation-5' => 'Rotated 90° CCW and flipped vertically',
3986 -'exif-orientation-6' => 'Rotated 90° CW',
 3986+'exif-orientation-6' => 'Rotated 90° CCW',
39873987 'exif-orientation-7' => 'Rotated 90° CW and flipped vertically',
3988 -'exif-orientation-8' => 'Rotated 90° CCW',
 3988+'exif-orientation-8' => 'Rotated 90° CW',
39893989
39903990 'exif-planarconfiguration-1' => 'chunky format',
39913991 'exif-planarconfiguration-2' => 'planar format',
Index: trunk/phase3/languages/messages/MessagesQqq.php
@@ -3340,7 +3340,9 @@
33413341
33423342 This field labels what the compression of the image is. It is commonly seen in Tiff images. It uses messages like {{msg-mw|exif-compression-1}} for the value. http://en.wikipedia.org/wiki/TIFF#TIFF_Compression_Tag has information about this field.',
33433343 'exif-photometricinterpretation' => 'Exif is a format for storing metadata in image files. See this [http://en.wikipedia.org/wiki/Exchangeable_image_file_format Wikipedia article] and the example at the bottom of [http://commons.wikimedia.org/wiki/File:Phalacrocorax-auritus-020.jpg this page on Commons]. The tags are explained [http://www.awaresystems.be/imaging/tiff/tifftags/privateifd/exif.html briefly] and [http://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf in further detail].',
3344 -'exif-orientation' => 'Exif is a format for storing metadata in image files. See this [http://en.wikipedia.org/wiki/Exchangeable_image_file_format Wikipedia article] and the example at the bottom of [http://commons.wikimedia.org/wiki/File:Phalacrocorax-auritus-020.jpg this page on Commons]. The tags are explained [http://www.awaresystems.be/imaging/tiff/tifftags/privateifd/exif.html briefly] and [http://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf in further detail].',
 3344+'exif-orientation' => 'Exif is a format for storing metadata in image files. See this [http://en.wikipedia.org/wiki/Exchangeable_image_file_format Wikipedia article] and the example at the bottom of [http://commons.wikimedia.org/wiki/File:Phalacrocorax-auritus-020.jpg this page on Commons]. The tags are explained [http://www.awaresystems.be/imaging/tiff/tifftags/privateifd/exif.html briefly] and [http://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf in further detail].
 3345+
 3346+For specific information on the orientation tag, see http://sylvana.net/jpegcrop/exif_orientation.html',
33453347 'exif-samplesperpixel' => 'Exif is a format for storing metadata in image files. See this [http://en.wikipedia.org/wiki/Exchangeable_image_file_format Wikipedia article] and the example at the bottom of [http://commons.wikimedia.org/wiki/File:Phalacrocorax-auritus-020.jpg this page on Commons]. The tags are explained [http://www.awaresystems.be/imaging/tiff/tifftags/privateifd/exif.html briefly] and [http://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf in further detail].',
33463348 'exif-planarconfiguration' => 'Exif is a format for storing metadata in image files. See this [http://en.wikipedia.org/wiki/Exchangeable_image_file_format Wikipedia article] and the example at the bottom of [http://commons.wikimedia.org/wiki/File:Phalacrocorax-auritus-020.jpg this page on Commons]. The tags are explained [http://www.awaresystems.be/imaging/tiff/tifftags/privateifd/exif.html briefly] and [http://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf in further detail].',
33473349 'exif-ycbcrsubsampling' => 'Exif is a format for storing metadata in image files. See this [http://en.wikipedia.org/wiki/Exchangeable_image_file_format Wikipedia article] and the example at the bottom of [http://commons.wikimedia.org/wiki/File:Phalacrocorax-auritus-020.jpg this page on Commons]. The tags are explained [http://www.awaresystems.be/imaging/tiff/tifftags/privateifd/exif.html briefly] and [http://www.kodak.com/global/plugins/acrobat/en/service/digCam/exifStandard2.pdf in further detail].',

Follow-up revisions

RevisionCommit summaryAuthorDate
r96849REL1_18: r96509, r96522, r96606, r96643, r96645, r96655, r96659, r96687, r967......reedy15:03, 12 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   05:08, 9 September 2011

How did you spot this?

#Comment by Bawolff (talk | contribs)   12:49, 9 September 2011

I uploaded the potrait-rotated.jpg image from the phpunit tests to my test wiki and noticed the orientation tag looked wrong. I then had a conversation with some nice folks on #wikimedia-commons to see if it was wrong or I was just loosing my mind ;)

As an aside, exiftool uses labels like "Rotate 270 CW" for orientation 8, presumably this means it needs to be rotated that way to fix the orientation, where we're using rotated which should logically mean what has already been done to the image to get it to the current state. That's possibly where the confusion has sprung up. This distinction doesn't matter for the other orientation tags, since those operations are their own inverse.

#Comment by Siebrand (talk | contribs)   07:04, 9 September 2011

No release notes update needed AFAICT.

Status & tagging log