r96640 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96639‎ | r96640 | r96641 >
Date:01:03, 9 September 2011
Author:krinkle
Status:ok
Tags:
Comment:
Remove wgProto from mw.config
* Introduced in r82575 spontaneously, but was never used.
* It was removed from PHP by Tim in r90193, who gracefully kept a work-around in place to still have a protocol available in mw.config.
* Since it was new in JS in 1.18 (which hasn't been released yet), I suggest we take it out right away, especially because the PHP counterpart has been deprecated as well. No release notes needed.
Modified paths:
  • /trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/resourceloader/ResourceLoaderStartUpModule.php
——@@ -69,10 +69,6 @@
7070 }
7171 }
7272
73 -
74 - $serverBits = wfParseUrl( $wgServer );
75 - $protocol = $serverBits ? $serverBits['scheme'] : 'http';
76 -
7773 // Build list of variables
7874 $vars = array(
7975 'wgLoadScript' => $wgLoadScript,
——@@ -108,7 +104,6 @@
109105 'wgFileCanRotate' => BitmapHandler::canRotate(),
110106 'wgAvailableSkins' => Skin::getSkinNames(),
111107 'wgExtensionAssetsPath' => $wgExtensionAssetsPath,
112 - 'wgProto' => $protocol,
113108 // MediaWiki sets cookies to have this prefix by default
114109 'wgCookiePrefix' => $wgCookiePrefix,
115110 'wgResourceLoaderMaxQueryLength' => $wgResourceLoaderMaxQueryLength,

Sign-offs

UserFlagDate
Nikerabbitinspected05:07, 9 September 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r97263REL1_18 MFT r93626, r96562, r96640, r96978, r97050reedy13:19, 16 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r82575Add missing to mw.configkrinkle21:24, 21 February 2011
r90193Removed $wgProto. Previously, setting this undocumented global variable to an...tstarling05:13, 16 June 2011

Status & tagging log