r96558 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96557‎ | r96558 | r96559 >
Date:12:45, 8 September 2011
Author:svemir
Status:ok (Comments)
Tags:
Comment:
pass the delimiter to preg_quote
Modified paths:
  • /trunk/extensions/SphinxSearch/SphinxMWSearch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SphinxSearch/SphinxMWSearch.php
——@@ -229,7 +229,7 @@
230230 $regexp_prefixes = array();
231231 foreach ( $all_prefixes as $prefix ) {
232232 if ( $prefix != '' ) {
233 - $regexp_prefixes[] = preg_quote( str_replace( ' ', '_', $prefix ) );
 233+ $regexp_prefixes[] = preg_quote( str_replace( ' ', '_', $prefix ), '/' );
234234 }
235235 }
236236

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96555streamlined preparePrefixRegexp and used preg_quote when building a regexpsvemir12:23, 8 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   13:30, 8 September 2011

Great! If you mention the revision number like this: r96555, this tool will automatically pick that up and add a note to that revision.

Status & tagging log