r96549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96548‎ | r96549 | r96550 >
Date:09:16, 8 September 2011
Author:raymond
Status:ok
Tags:
Comment:
Add a CSS class to the metadata/EXIF table row which shows the text 'Show extended details' and hide this row for printing. Useless because you cannot click on the paper :)
Modified paths:
  • /trunk/phase3/resources/mediawiki.action/mediawiki.action.view.metadata.js (modified) (history)
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/commonPrint.css
@@ -345,3 +345,8 @@
346346 widows: 3;
347347 orphans: 3;
348348 }
 349+
 350+/* Metadata/EXIF rendering */
 351+tr.mw-metadata-show-hide-extended {
 352+ display: none;
 353+}
Index: trunk/phase3/resources/mediawiki.action/mediawiki.action.view.metadata.js
@@ -14,7 +14,7 @@
1515 return;
1616 }
1717
18 - var $row = $( '<tr></tr>' );
 18+ var $row = $( '<tr class="mw-metadata-show-hide-extended"></tr>' );
1919 var $col = $( '<td colspan="2"></td>' );
2020
2121 var $link = $( '<a></a>', {

Follow-up revisions

RevisionCommit summaryAuthorDate
r96580followup r96549: Add the 'display:none' to the existing section instead of op...raymond16:13, 8 September 2011

Status & tagging log