r96537 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96536‎ | r96537 | r96538 >
Date:01:52, 8 September 2011
Author:demon
Status:resolved
Tags:
Comment:
Last fix for r96529, I swear...only CommonSettings.php needs interpretPath(). Core loadSettings() already returns LocalSettings with $IP prefixed.
Modified paths:
  • /trunk/extensions/WikimediaMaintenance/WikimediaMaintenance.php (modified) (history)
  • /trunk/phase3/maintenance/doMaintenance.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/doMaintenance.php
@@ -87,6 +87,8 @@
8888 // Require the configuration (probably LocalSettings.php)
8989 require( MWInit::interpretedPath( $maintenance->loadSettings() ) );
9090 }
 91+// Require the configuration (probably LocalSettings.php)
 92+require( $maintenance->loadSettings() );
9193
9294 if ( $maintenance->getDbType() === Maintenance::DB_ADMIN &&
9395 is_readable( "$IP/AdminSettings.php" ) )
Index: trunk/extensions/WikimediaMaintenance/WikimediaMaintenance.php
@@ -69,6 +69,6 @@
7070 define( 'TESTWIKI', 1 );
7171 }
7272 }
73 - return '../wmf-config/CommonSettings.php';
 73+ return MWInit::interpretedPath( '../wmf-config/CommonSettings.php' );
7474 }
7575 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r96538Stupid merge conflicts, fix r96537demon01:54, 8 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96529Tweaks to WikimediaMaintenance:...demon00:35, 8 September 2011

Status & tagging log