r96504 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96503‎ | r96504 | r96505 >
Date:21:37, 7 September 2011
Author:reedy
Status:ok
Tags:
Comment:
Fix xor in r96501
Modified paths:
  • /trunk/extensions/CodeReview/backend/DiffHighlighter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/DiffHighlighter.php
@@ -35,7 +35,7 @@
3636 * @return string
3737 */
3838 function render( $text, CodeRepository $repo = null, CodeRevision $rev = null ) {
39 - if( $repo ^ $rev ) {
 39+ if( $repo xor $rev ) {
4040 throw new MWException( __METHOD__ . " must have both repository and revision or none of them\n" );
4141 } elseif( $repo && $rev ) {
4242 $this->repo = $repo;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96501Fix whitespace...reedy21:14, 7 September 2011

Status & tagging log