r96503 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96502‎ | r96503 | r96504 >
Date:21:33, 7 September 2011
Author:yaron
Status:deferred
Tags:
Comment:
Added UTF8-encoding, for the handling of non-Latin characters in IE; along with some minor fixes
Modified paths:
  • /trunk/extensions/SemanticForms/specials/SF_UploadWindow2.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/specials/SF_UploadWindow2.php
@@ -383,6 +383,8 @@
384384 }
385385
386386 $basename = str_replace( '_', ' ', $basename );
 387+ // UTF8-decoding is needed for IE
 388+ $basename = utf8_decode( $basename );
387389 $output = ' <script type="text/javascript">' . "\n";
388390 if ( $this->mDelimiter == null ) {
389391 $output .= <<<END
@@ -926,7 +928,7 @@
927929 'section' => 'options',
928930 );
929931 }
930 - $descriptor['wpDestFileWarningAck'] = array(
 932+ $descriptor['DestFileWarningAck'] = array(
931933 'type' => 'hidden',
932934 'id' => 'wpDestFileWarningAck',
933935 'default' => $this->mDestWarningAck ? '1' : '',
@@ -1014,13 +1016,12 @@
10151017 protected function addUploadJS( $autofill = true ) {
10161018 global $wgUseAjax, $wgAjaxUploadDestCheck, $wgAjaxLicensePreview;
10171019 global $wgStrictFileExtensions;
1018 - global $wgEnableFirefogg, $wgEnableJS2system;
 1020+ global $wgEnableJS2system;
10191021 global $wgOut;
10201022
10211023 $scriptVars = array(
10221024 'wgAjaxUploadDestCheck' => $wgUseAjax && $wgAjaxUploadDestCheck,
10231025 'wgAjaxLicensePreview' => $wgUseAjax && $wgAjaxLicensePreview,
1024 - 'wgEnableFirefogg' => (bool)$wgEnableFirefogg,
10251026 'wgUploadAutoFill' => (bool)$autofill &&
10261027 // If we received mDestFile from the request, don't autofill
10271028 // the wpDestFile textbox