r96487 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96486‎ | r96487 | r96488 >
Date:20:28, 7 September 2011
Author:hashar
Status:ok (Comments)
Tags:
Comment:
complement r96386 tests
Modified paths:
  • /trunk/phase3/tests/phpunit/includes/IPTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/IPTest.php
@@ -276,7 +276,7 @@
277277 foreach ( $private as $p ) {
278278 $this->assertFalse( IP::isPublic( $p ), "$p is not a public IP address" );
279279 }
280 - $public = array( '2001:5c0:1000:a::133', 'fc::3' );
 280+ $public = array( '2001:5c0:1000:a::133', 'fc::3', '00FC::' );
281281 foreach ( $public as $p ) {
282282 $this->assertTrue( IP::isPublic( $p ), "$p is a public IP address" );
283283 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96386Fixed typo in ipv6 private IP range list and added test (bug 30739)aaron23:15, 6 September 2011

Comments

#Comment by Hashar (talk | contribs)   20:29, 7 September 2011

backport not really needed.

Status & tagging log