r96458 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96457‎ | r96458 | r96459 >
Date:17:41, 7 September 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
added check question type, unlisted survey special and i18n tweak
Modified paths:
  • /trunk/extensions/Survey/Survey.i18n.php (modified) (history)
  • /trunk/extensions/Survey/Survey.php (modified) (history)
  • /trunk/extensions/Survey/includes/SurveyQuestion.php (modified) (history)
  • /trunk/extensions/Survey/resources/ext.survey.js (modified) (history)
  • /trunk/extensions/Survey/specials/SpecialSurvey.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Survey/specials/SpecialSurvey.php
@@ -19,7 +19,7 @@
2020 * @since 0.1
2121 */
2222 public function __construct() {
23 - parent::__construct( 'Survey', 'surveyadmin' );
 23+ parent::__construct( 'Survey', 'surveyadmin', false );
2424 }
2525
2626 /**
Index: trunk/extensions/Survey/includes/SurveyQuestion.php
@@ -18,6 +18,7 @@
1919 public static $TYPE_SELECT = 2;
2020 public static $TYPE_RADIO = 3;
2121 public static $TYPE_TEXTAREA = 4;
 22+ public static $TYPE_CHECK = 5;
2223
2324 /**
2425 * @see SurveyDBClass::getDBTable()
Index: trunk/extensions/Survey/resources/ext.survey.js
@@ -60,6 +60,7 @@
6161 this.SELECT = 2;
6262 this.RADIO = 3;
6363 this.TEXTAREA = 4;
 64+ this.CHECK = 5;
6465 } );
6566
6667 this.getTypeSelector = function( value, attributes ) {
Index: trunk/extensions/Survey/Survey.php
@@ -140,6 +140,7 @@
141141 'survey-question-type-select',
142142 'survey-question-type-radio',
143143 'survey-question-type-textarea',
 144+ 'survey-question-type-check',
144145 'survey-question-label-nr',
145146 'survey-special-label-required',
146147 'survey-special-label-type',
Index: trunk/extensions/Survey/Survey.i18n.php
@@ -67,11 +67,12 @@
6868 'survey-special-label-button' => 'Add question',
6969 'survey-special-label-addquestion' => 'New question',
7070 'survey-special-label-add' => 'New question name',
71 - 'survey-question-type-text' => 'Free text',
 71+ 'survey-question-type-text' => 'Single line text field',
7272 'survey-question-type-number' => 'Number',
7373 'survey-question-type-select' => 'Dropdown menu',
7474 'survey-question-type-radio' => 'Radio boxes',
75 - 'survey-question-type-textarea' => 'Text area',
 75+ 'survey-question-type-textarea' => 'Multi line text field',
 76+ 'survey-question-type-check' => 'Checkbox',
7677 'survey-question-label-nr' => 'Question #$1',
7778 'survey-special-label-required' => 'Question is required',
7879 'survey-special-label-type' => 'Question type',

Status & tagging log