r96457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96456‎ | r96457 | r96458 >
Date:17:25, 7 September 2011
Author:siebrand
Status:ok
Tags:
Comment:
Ran stylize.php. Required manual corrections:
* $params[$index-1] was changed to $params[$index -1] instead of $params[$index - 1]
* ///!< @var string was changed to /// !< @var string, but should have remain unchanged.
Modified paths:
  • /trunk/phase3/includes/logging/LogEntry.php (modified) (history)
  • /trunk/phase3/includes/logging/LogFormatter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/logging/LogEntry.php
@@ -122,7 +122,7 @@
123123 $fields = array(
124124 'log_id', 'log_type', 'log_action', 'log_timestamp',
125125 'log_user', 'log_user_text',
126 - 'log_namespace', 'log_title', //unused log_page
 126+ 'log_namespace', 'log_title', // unused log_page
127127 'log_comment', 'log_params', 'log_deleted',
128128 'user_id', 'user_name', 'user_editcount',
129129 );
@@ -319,7 +319,7 @@
320320 }
321321
322322 /**
323 - * Set extra log parameters.
 323+ * Set extra log parameters.
324324 * You can pass params to the log action message
325325 * by prefixing the keys with a number and colon.
326326 * The numbering should start with number 4, the
Index: trunk/phase3/includes/logging/LogFormatter.php
@@ -171,7 +171,7 @@
172172
173173 if ( $entry->isLegacy() ) {
174174 foreach ( $entry->getParameters() as $index => $value ) {
175 - $params[$index+3] = $value;
 175+ $params[$index + 3] = $value;
176176 }
177177 }
178178
@@ -179,7 +179,7 @@
180180 foreach ( $entry->getParameters() as $key => $value ) {
181181 if ( strpos( $key, ':' ) === false ) continue;
182182 list( $index, $type, $name ) = explode( ':', $key, 3 );
183 - $params[$index-1] = $value;
 183+ $params[$index - 1] = $value;
184184 }
185185
186186 /* Message class doesn't like non consecutive numbering.

Status & tagging log