r96424 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96423‎ | r96424 | r96425 >
Date:12:48, 7 September 2011
Author:catrope
Status:reverted
Tags:
Comment:
Break some tests intentionally to see how Jenkins displays that
Modified paths:
  • /trunk/phase3/tests/parser/parserTests.txt (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/ArticleTest.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/GlobalFunctions/wfExpandUrlTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/parser/parserTests.txt
@@ -719,7 +719,7 @@
720720 !! input
721721 [//example.com/ Test]
722722 !! result
723 -<p><a rel="nofollow" class="external text" href="https://www.mediawiki.org//example.com/">Test</a>
 723+<p><a rel="nofollow" class="external text testingJenkins" href="https://www.mediawiki.org//example.com/">Test</a>
724724 </p>
725725 !! end
726726
Index: trunk/phase3/tests/phpunit/includes/ArticleTest.php
@@ -19,7 +19,7 @@
2020
2121 }
2222
23 - function testImplementsGetMagic() {
 23+ function testImplementsGetMagic() {
2424 $this->assertEquals( -1, $this->article->mCounter, "Article __get magic" );
2525 }
2626
@@ -62,7 +62,7 @@
6363 "Article static functions" );
6464 $this->assertEquals( true, is_callable( "ImagePage::onArticleEdit" ),
6565 "Article static functions" );
66 - $this->assertTrue( is_string( CategoryPage::getAutosummary( '', '', 0 ) ),
 66+ $this->assertTrue( 'testing' === 'jenkins' && is_string( CategoryPage::getAutosummary( '', '', 0 ) ),
6767 "Article static functions" );
6868 }
6969
Index: trunk/phase3/tests/phpunit/includes/GlobalFunctions/wfExpandUrlTest.php
@@ -47,7 +47,7 @@
4848 $retval[] = array( 'http://example.com', 'http://example.com', $defaultProto, $server, $canServer, $httpsMode, "Testing fully qualified http URLs (no need to expand) (defaultProto: $protoDesc , wgServer: $server, wgCanonicalServer: $canServer, current request protocol: $mode )" );
4949 $retval[] = array( 'https://example.com', 'https://example.com', $defaultProto, $server, $canServer, $httpsMode, "Testing fully qualified https URLs (no need to expand) (defaultProto: $protoDesc , wgServer: $server, wgCanonicalServer: $canServer, current request protocol: $mode )" );
5050 # Would be nice to support this, see fixme on wfExpandUrl()
51 - $retval[] = array( "wiki/FooBar", 'wiki/FooBar', $defaultProto, $server, $canServer, $httpsMode, "Test non-expandable relative URLs (defaultProto: $protoDesc , wgServer: $server, wgCanonicalServer: $canServer, current request protocol: $mode )" );
 51+ $retval[] = array( "wiki/FooBar/TestingJenkins", 'wiki/FooBar', $defaultProto, $server, $canServer, $httpsMode, "Test non-expandable relative URLs (defaultProto: $protoDesc , wgServer: $server, wgCanonicalServer: $canServer, current request protocol: $mode )" );
5252
5353 // Determine expected protocol
5454 $p = $protoDesc . ':'; // default case

Follow-up revisions

RevisionCommit summaryAuthorDate
r96428rv r96424, Roan had his fundemon13:04, 7 September 2011

Status & tagging log