r96391 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r96390‎ \| r96391 \| r96392 >
Date:	01:07, 7 September 2011
Author:	khorn
Status:	ok (Comments)
Tags:	fundraising
Comment:	Fundraiser Team: More work for card #268 (and beyond). Have pulled (and exploded) a number of moving pieces out from under PayflowPro's umbrella. Then put these pieces back somewhere with the general goal being that the parts are now: * Modular * Testable * Only in one place (as opposed to, say, five) While the abstraction (and exploding) is still a work in progress, we can now clumsily use pre-existing forms to send data up to GlobalCollect and get a meaningful response back. Unit tests for the new objects are next.
Modified paths:	/branches/fundraising/extensions/DonationInterface/donationinterface.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_common/DonationData.php (added) (history) /branches/fundraising/extensions/DonationInterface/gateway_common/gateway.adapter.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/Form.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/OneStepTwoColumn.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/RapidHtml.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnLetter.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnLetter2.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnLetter3.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnLetter4.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnLetter5.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnLetter6.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnLetter7.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoColumnPayPal.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnLetter3.php (modified) (history) /branches/fundraising/extensions/DonationInterface/gateway_forms/TwoStepTwoColumnPremiumUS.php (modified) (history) /branches/fundraising/extensions/DonationInterface/globalcollect_gateway/globalcollect.adapter.php (modified) (history) /branches/fundraising/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.body.php (modified) (history) /branches/fundraising/extensions/DonationInterface/globalcollect_gateway/globalcollect_gateway.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/api_payflowpro_gateway.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/extras/extras.body.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/ccfd/HTTPBase.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/minfraud.body.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/extras/minfraud/tests/minfraudTest.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/extras/recaptcha/recaptcha.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/Form.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/OneStepTwoColumn.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/RapidHtml.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/SingleColumn.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter2.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter3.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter4.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter5.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter6.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnLetter7.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumnPayPal.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter2.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetterCA.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnPremium.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnPremiumUS.php (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/Form.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/SingleColumn.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter4.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter5.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter6.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter7.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter2.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter3.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnPremium.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnPremiumUS.css (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/html/demo.html (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/card-amex.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/card-discover.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/card-mastercard.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/card-paypal.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/card-visa.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/continue-button.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/countryCodes.inc (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/credit_card_logos.gif (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/credit_card_logos2.gif (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/credit_card_logos3.gif (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/donate_with_paypal.gif (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/padlock.gif (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/payflowUser.inc (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/paypal.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/provinceAbbreviations.inc (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/rapidssl_ssl_certificate-nonanimated.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/rapidssl_ssl_certificate.gif (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/stateAbbreviations.inc (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/submit-donation-button.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wikipedia-ten-tshirt-front.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ab-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/am-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/an-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ar-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ast-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/az-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/be-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/bg-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/bn-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/bo-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ca-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/chr-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/cr-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/cs-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/cu-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/cy-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/diq-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/dv-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/el-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/en-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/eo-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/et-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/fa-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ff-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/fr-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/fy-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/gn-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/gu-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/haw-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/he-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/hi-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ht-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/io-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/iu-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ja-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ka-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/kk-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ko-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ku-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/la-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/lt-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/lv-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/mk-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ml-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/nrm-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/nv-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/qu-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ru-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/sah-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/sg-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/si-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/sl-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/sr-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ta-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/te-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/th-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/tr-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/uk-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/ur-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/vo-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/forms/includes/wordmarks/zh-wordmark.png (deleted) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro.adapter.php (added) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history) /branches/fundraising/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.php (modified) (history)

Comments

#Comment by Khorn (WMF) (talk | contribs) 18:39, 23 September 2011

Please note that this branch is in the middle of a serious refactoring, and is by no means ready to be merged back into trunk. (Latest DonationInterface branch rev at the time of this comment is r97833.)

#Comment by Jpostlethwaite (talk | contribs) 19:28, 23 September 2011

This code is in development.

Status & tagging log

19:28, 23 September 2011 Jpostlethwaite (talk | contribs) changed the status of r96391 [removed: new added: ok]
20:43, 9 September 2011 Awjrichards (talk | contribs) changed the tags for r96391 [added: fundraising]