r96310 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96309‎ | r96310 | r96311 >
Date:23:10, 5 September 2011
Author:krinkle
Status:ok (Comments)
Tags:
Comment:
mediawiki.html: Attribute values may also be numbers (rather than boolean or string). Just make sure that whatever is passed becomes a string (not using .toString as not everything has a toString method)
* Follows-up r96307
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.js
——@@ -1247,7 +1247,7 @@
12481248 } else if ( v === false ) {
12491249 continue;
12501250 }
1251 - s += ' ' + attrName + '="' + this.escape( v ) + '"';
 1251+ s += ' ' + attrName + '="' + this.escape( '' + v ) + '"';
12521252 }
12531253 if ( contents === undefined || contents === null ) {
12541254 // Self close tag

Follow-up revisions

RevisionCommit summaryAuthorDate
r104753MFT r96307, r96310reedy21:27, 30 November 2011
r1047541.18wmf1 Merge r104753reedy21:29, 30 November 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96307mediawiki.html: mediawiki.html: Add support for numbers and booleans...krinkle21:51, 5 September 2011

Comments

#Comment by Hashar (talk | contribs)   11:15, 5 December 2011

Merged in wmf branch by r104754

Status & tagging log