r96281 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96280‎ | r96281 | r96282 >
Date:15:30, 5 September 2011
Author:dantman
Status:ok (Comments)
Tags:
Comment:
Pass the key for the skin being created to the constructor of a skin. This is just something that's been bothering me for awhile, without this it's hard to create extensions that dynamically load skins and implement the skin conversion functionality in a central class.
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
——@@ -156,7 +156,7 @@
157157 }
158158 }
159159 }
160 - $skin = new $className;
 160+ $skin = new $className( $key );
161161 return $skin;
162162 }
163163

Comments

#Comment by Aaron Schulz (talk | contribs)   22:12, 3 November 2011

Maybe the constructor should be explicit about this parameter.

#Comment by Dantman (talk | contribs)   22:23, 3 November 2011

Explicit. Actually use it? I'll need to double check compatibility later.

Status & tagging log