r96174 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96173‎ | r96174 | r96175 >
Date:10:23, 3 September 2011
Author:maxsem
Status:ok
Tags:
Comment:
Fix r87731: update site stats only when explicitly asked to do so
Modified paths:
  • /trunk/phase3/includes/installer/DatabaseUpdater.php (modified) (history)
  • /trunk/phase3/includes/installer/OracleUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/update.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/update.php
@@ -110,7 +110,7 @@
111111
112112 $shared = $this->hasOption( 'doshared' );
113113
114 - $updates = array('core','extensions');
 114+ $updates = array( 'core', 'extensions', 'stats' );
115115 if( !$this->hasOption('nopurge') ) {
116116 $updates[] = 'purge';
117117 }
Index: trunk/phase3/includes/installer/DatabaseUpdater.php
@@ -189,7 +189,7 @@
190190 *
191191 * @param $what Array: what updates to perform
192192 */
193 - public function doUpdates( $what = array( 'core', 'extensions', 'purge' ) ) {
 193+ public function doUpdates( $what = array( 'core', 'extensions', 'purge', 'stats' ) ) {
194194 global $wgVersion;
195195
196196 $what = array_flip( $what );
@@ -206,7 +206,7 @@
207207 if( isset( $what['purge'] ) ) {
208208 $this->purgeCache();
209209 }
210 - if ( isset( $what['core'] ) ) {
 210+ if ( isset( $what['stats'] ) ) {
211211 $this->checkStats();
212212 }
213213 }
Index: trunk/phase3/includes/installer/OracleUpdater.php
@@ -157,7 +157,7 @@
158158 *
159159 * @param $what array
160160 */
161 - public function doUpdates( $what = array( 'core', 'extensions', 'purge' ) ) {
 161+ public function doUpdates( $what = array( 'core', 'extensions', 'purge', 'stats' ) ) {
162162 parent::doUpdates( $what );
163163
164164 $this->db->query( 'BEGIN fill_wiki_info; END;' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r965111.18: MFT r96163, r96174, r96212, r96217, r96218, r96271, r96273, r96306, r96...catrope22:07, 7 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r87731Automatic testing of SQLite updates from all (previoisly) supported versionsmaxsem16:41, 9 May 2011

Status & tagging log