r96159 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r96158‎ | r96159 | r96160 >
Date:22:41, 2 September 2011
Author:hashar
Status:reverted (Comments)
Tags:
Comment:
Get ride of old Tag form

Tags can be deleted with ajax. Input box to add tag is below.
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionView.php
——@@ -341,14 +341,17 @@
342342 array_map(
343343 array( $this, 'formatTag' ),
344344 $tags )
345 - ) . '&#160;';
 345+ ) . '<br/>';
346346 }
347347 if ( $wgUser->isAllowed( 'codereview-add-tag' ) ) {
 348+ $list .= Xml::inputLabel( wfMsg( 'code-rev-tag-add' ), 'wpTag', 'wpTag', 20,
 349+ self::listTags( $this->mAddTags ) );
348350 $list .= Xml::Element( 'span', array(
349351 'id' => "codereview-add-tag",
350352 'title' => wfMsg( 'code-rev-tag-addtag-tooltip' ),
351353 ), '+' ); // TODO: replace '+' with a message
352 - $list .= $this->addTagForm( $this->mAddTags, $this->mRemoveTags );
 354+ //old tag form:
 355+ //$list .= $this->addTagForm( $this->mAddTags, $this->mRemoveTags );
353356 }
354357 return $list;
355358 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r105518Reverting r96158, r96159: incomplete project, can't be deployed as is, see CR...tstarling06:33, 8 December 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r96158(bug 26084) add some ajax to easily delete tags...hashar22:41, 2 September 2011

Comments

#Comment by Hashar (talk | contribs)   22:54, 2 September 2011

The green '+' sign next to the tag input should let us submit the new tags using ajax. Then we will have to update the tag list.

#Comment by Tim Starling (talk | contribs)   06:02, 8 December 2011

How are you meant to delete tags if you have JavaScript disabled?

Status & tagging log