r96081 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96080‎ | r96081 | r96082 >
Date:06:58, 2 September 2011
Author:freakolowsky
Status:reverted (Comments)
Tags:
Comment:
* added redundand join condition for index usage as per comment on CR r88008
Modified paths:
  • /trunk/phase3/includes/specials/SpecialContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialContributions.php
@@ -518,11 +518,11 @@
519519 $index = 'user_timestamp';
520520 # @todo FIXME: Other groups may have 'bot' rights
521521 $join_conds['user_groups'] = array( 'LEFT JOIN', "ug_user = rev_user AND ug_group = 'bot'" );
522 - $join_conds['recentchanges'] = array( 'INNER JOIN', "rev_id = rc_this_oldid" );
 522+ $join_conds['recentchanges'] = array( 'INNER JOIN', "rev_id = rc_this_oldid AND rev_timestamp = rc_timestamp" );
523523 } else {
524524 $tables = array( 'recentchanges', 'page', 'revision' );
525525 $condition['rev_user_text'] = $this->target;
526 - $join_conds['recentchanges'] = array( 'INNER JOIN', "rev_id = rc_this_oldid" );
 526+ $join_conds['recentchanges'] = array( 'INNER JOIN', "rev_id = rc_this_oldid AND rev_timestamp = rc_timestamp" );
527527 $index = 'usertext_timestamp';
528528 }
529529 if( $this->deletedOnly ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r96306Revert r88008 (add size difference to Special:Contributions) and its large gr...catrope21:47, 5 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88008* bug 24037freakolowsky17:11, 13 May 2011

Comments

#Comment by Catrope (talk | contribs)   21:48, 5 September 2011

Hmm, re-adding 1.18 tag, needs to be merged so its revert in r96306 will merge cleanly.

Status & tagging log