r96030 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r96029‎ | r96030 | r96031 >
Date:19:41, 1 September 2011
Author:pgehres
Status:ok (Comments)
Tags:
Comment:
Changes for tomorrow's US test
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/globalcollect_test.html (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/html/globalcollect_test.html
@@ -1,14 +1,10 @@
 2+<link rel="stylesheet" href="@script_path/skins/vector/main-ltr.css" />
 3+<link rel="stylesheet" href="@script_path/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter3.css" />
 4+<link rel="stylesheet" href="@script_path/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.css" />
25 <style>
36 .step2hidden{ display:none; }
 7+ #footer-places { display:none; }
48 </style>
5 -<link rel="stylesheet" href="https://payments.wikimedia.org/skins/vector/main-ltr.css" />
6 -<link rel="stylesheet" href="https://payments.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter3.css" />
7 -
8 -<link rel="stylesheet" href="https://payments.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.css" />
9 -
10 -
11 -
12 -
139 <table width="100%" cellspacing="0" cellpadding="0" border="0">
1410 <tr>
1511 <td id="appeal" valign="top">
@@ -71,28 +67,25 @@
7268 <td class="amount_header">Description</td>
7369 <td class="amount_header" style="text-align:right;width:75px;">Amount
7470 </td>
75 - <td class="amount_header" style="text-align:right;width:75px;">Currency
76 - </td>
 71+
7772 </tr>
7873 <tr>
7974 <td class="amount_data">Donation</td>
80 - <td class="amount_data" style="text-align:right;width:75px;">@amount<input
 75+ <td class="amount_data" style="text-align:right;width:75px;">$ @amount<input
8176 type="hidden" value="@amount" name="amount"/></td>
82 - <td class="amount_data" style="text-align:right;width:75px;">@currency_code<input
83 - type="hidden" values="@currency_code" name="currency_code"/></td>
 77+
8478 </tr>
8579 </table>
8680 </td>
8781 </tr>
8882 <tr class="step2hidden">
8983 <td colspan="2"><h3 class="cc_header">Billing information<img
90 - src="https://test-payments.tesla.usability.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/includes/padlock.gif"
 84+ src="@script_path/extensions/DonationInterface/payflowpro_gateway/includes/padlock.gif"
9185 style="vertical-align:baseline;margin-left:8px;"/></h3></td>
9286 </tr>
9387 <tr>
9488 <td class="label"></td>
95 - <td><img
96 - src="https://payments.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif"/>
 89+ <td><img src="@script_path/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" style="padding-top: 10px;"/>
9790 </td>
9891 </tr>
9992 <tr>
@@ -138,119 +131,24 @@
139132 </td>
140133 </tr>
141134 <tr>
142 - <td colspan=2><span class="creditcard-error-msg"></span></td>
143 - </tr>
144 - <tr>
145 - <td colspan=2><span class="creditcard-error-msg"></span></td>
146 - </tr>
147 - <tr class="step2hidden">
148 - <td class="label"><label for="fname">Name on card</label></td>
149 - <td><input name="fname" size="30" value="@fname" type="text"
150 - onfocus="clearField( this, &#039;First name&#039; )" maxlength="25"
151 - class="required" id="fname"/>
152 - <input name="lname" size="30" value="@lname"
153 - type="text"
154 - onfocus="clearField( this, &#039;Last name&#039; )"
155 - maxlength="25" id="lname"/></td>
156 - </tr>
157 - <tr class="step2hidden">
158 - <td colspan=2><span class="creditcard-error-msg"></span></td>
159 - </tr>
160 - <tr class="step2hidden">
161 - <td class="label"><label for="street">Billing address</label></td>
162 - <td><input name="street" size="30" value="@street" type="text"
163 - onfocus="clearField( this, &#039;Street&#039; )" maxlength="100"
164 - id="street" class="fullwidth"/></td>
165 - </tr>
166 - <tr class="step2hidden">
167 - <td colspan=2><span class="creditcard-error-msg"></span></td>
168 - </tr>
169 - <tr class="step2hidden">
170135 <td class="label"></td>
171 - <td><input name="city" size="18" value="@city" type="text"
172 - onfocus="clearField( this, &#039;City&#039; )" maxlength="40" id="city"/>
173 - <select name="state" id="state">
174 - <option value=""/>
175 - <option value="AK">AK</option>
176 - <option value="AL">AL</option>
177 - <option value="AR">AR</option>
178 - <option value="AZ">AZ</option>
179 - <option value="CA">CA</option>
180 - <option value="CO">CO</option>
181 - <option value="CT">CT</option>
182 - <option value="DC">DC</option>
183 - <option value="DE">DE</option>
184 - <option value="FL">FL</option>
185 - <option value="GA">GA</option>
186 - <option value="HI">HI</option>
187 - <option value="IA">IA</option>
188 - <option value="ID">ID</option>
189 - <option value="IL">IL</option>
190 - <option value="IN">IN</option>
191 - <option value="KS">KS</option>
192 - <option value="KY">KY</option>
193 - <option value="LA">LA</option>
194 - <option value="MA">MA</option>
195 - <option value="MD">MD</option>
196 - <option value="ME">ME</option>
197 - <option value="MI">MI</option>
198 - <option value="MN">MN</option>
199 - <option value="MO">MO</option>
200 - <option value="MS">MS</option>
201 - <option value="MT">MT</option>
202 - <option value="NC">NC</option>
203 - <option value="ND">ND</option>
204 - <option value="NE">NE</option>
205 - <option value="NH">NH</option>
206 - <option value="NJ">NJ</option>
207 - <option value="NM">NM</option>
208 - <option value="NV">NV</option>
209 - <option value="NY">NY</option>
210 - <option value="OH">OH</option>
211 - <option value="OK">OK</option>
212 - <option value="OR">OR</option>
213 - <option value="PA">PA</option>
214 - <option value="PR">PR</option>
215 - <option value="RI">RI</option>
216 - <option value="SC">SC</option>
217 - <option value="SD">SD</option>
218 - <option value="TN">TN</option>
219 - <option value="TX">TX</option>
220 - <option value="UT">UT</option>
221 - <option value="VA">VA</option>
222 - <option value="VT">VT</option>
223 - <option value="WA">WA</option>
224 - <option value="WI">WI</option>
225 - <option value="WV">WV</option>
226 - <option value="WY">WY</option>
227 - <option value="AA">AA</option>
228 - <option value="AE">AE</option>
229 - <option value="AP">AP</option>
230 - </select> <input name="zip" size="5" value="" type="text"
231 - onfocus="clearField( this, &#039;Zip code&#039; )"
232 - maxlength="10" id="zip"/><input type="hidden" value="@country"
233 - name="country"/></td>
234 - </tr>
235 - <tr class="step2hidden">
236 - <td colspan=2><span class="creditcard-error-msg"></span></td>
237 - </tr>
238 - <tr class="step2hidden">
239 - <td class="label"><label for="emailAdd">E-mail receipt to</label></td>
240 - <td><input name="emailAdd" size="30" value="@emailAdd" type="text"
241 - onfocus="clearField( this, &#039;Email address&#039; )" maxlength="64"
242 - id="emailAdd" class="fullwidth"/></td>
243 - </tr>
244 - <tr>
245 - <td class="label"></td>
246136 <td>
247 - <div id="mw-donate-submit-button">&#160;<br/><input
248 - src="https://test-payments.tesla.usability.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/includes/submit-donation-button.png"
249 - alt="Submit donation" type="image"/></div>
250 - <div class="mw-donate-submessage" id="payflowpro_gateway-donate-submessage"><img src="https://payments.wikimedia.org/extensions/DonationInterface/payflowpro_gateway/includes/padlock.gif" style="vertical-align:baseline;margin-right:4px;">Your credit / debit card will be securely processed.</div>
 137+ <div id="mw-donate-submit-button"><input style="margin-top:19px;"
 138+ src="@script_path/extensions/DonationInterface/payflowpro_gateway/includes/submit-donation-button.png" alt="Submit donation" type="image"/></div>
 139+ <div class="mw-donate-submessage" id="payflowpro_gateway-donate-submessage"><img src="@script_path/extensions/DonationInterface/payflowpro_gateway/includes/padlock.gif" style="vertical-align:baseline;margin-right:4px;">Your credit / debit card will be securely processed.</div>
251140 </td>
252141 </tr>
253142 </table>
254143 </div>
 144+ <input type="hidden" name="emailAdd" size="30" value="@emailAdd" onfocus="clearField( this, &#039;Email address&#039; )" maxlength="64"id="emailAdd" class="fullwidth"/>
 145+ <input type="hidden" name="fname" size="30" value="@fname"onfocus="clearField( this, &#039;First name&#039; )" maxlength="25" class="required" id="fname"/>
 146+ <input type="hidden" name="lname" size="30" value="@lname" onfocus="clearField( this, &#039;Last name&#039; )" maxlength="25" id="lname"/>
 147+ <input type="hidden" name="street" size="30" value="@street" onfocus="clearField( this, &#039;Street&#039; )" maxlength="100" id="street" class="fullwidth"/>
 148+ <input type="hidden" name="city" size="18" value="@city" onfocus="clearField( this, &#039;City&#039; )" maxlength="40" id="city"/>
 149+ <input type="hidden" name="state" size="18" value="@state" maxlength="40" id="state"/>
 150+ <input type="hidden" name="zip" size="5" value="@zip" onfocus="clearField( this, &#039;Zip code&#039; )"maxlength="10" id="zip"/>
 151+ <input type="hidden" name="country" value="@country"/>
 152+
255153 <input type="hidden" value="@utm_source" name="utm_source"/>
256154 <input type="hidden" value="@utm_medium" name="utm_medium"/>
257155 <input type="hidden" value="@utm_campaign" name="utm_campaign"/>
@@ -274,7 +172,7 @@
275173 <div style="text-align:center;">* * *</div>
276174 <div class="">We do not store your credit card information, and your personal data is
277175 subject to our <a target="_new"
278 - href="http://wikimediafoundation.org/wiki/Donor_Privacy_Policy">privacy
 176+ href="http://wikimediafoundation.org/wiki/Donor_Privacy_Policy">donor privacy
279177 policy</a>.
280178 </div>
281179 <div class="">There are <a target="_new"

Follow-up revisions

RevisionCommit summaryAuthorDate
r96035Re-fixed donor privacy policy link...awjrichards20:25, 1 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95937Adding test 2 with billing information above CC details.pgehres05:36, 1 September 2011

Comments

#Comment by Awjrichards (talk | contribs)   20:26, 1 September 2011

Donation privacy policy URLs are wrong - I fixed this in r96035

Status & tagging log