r95998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95997‎ | r95998 | r95999 >
Date:15:22, 1 September 2011
Author:krinkle
Status:resolved (Comments)
Tags:
Comment:
Fix r95997: Update unit test
Modified paths:
  • /trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/qunit/suites/resources/mediawiki/mediawiki.test.js
@@ -88,7 +88,7 @@
8989
9090 var hello = mw.message( 'hello' );
9191
92 - equal( hello.format, 'parse', 'Message property "format" defaults to "parse"' );
 92+ equal( hello.format, 'plain', 'Message property "format" defaults to "parse"' );
9393 strictEqual( hello.map, mw.messages, 'Message property "map" defaults to the global instance in mw.messages' );
9494 equal( hello.key, 'hello', 'Message property "key" (currect key)' );
9595 deepEqual( hello.parameters, [], 'Message property "parameters" defaults to an empty array' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r96097Follow-up r95998: Update the test title as well. r95998 changed 'parse' to 'p...krinkle14:52, 2 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95997Change default value for format property of mw.message object from 'parse' to...krinkle15:20, 1 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   20:07, 1 September 2011

Shouldn't the comment be updated also?

#Comment by Krinkle (talk | contribs)   14:52, 2 September 2011

Thanks, done.

Status & tagging log