r95947 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95946‎ | r95947 | r95948 >
Date:08:21, 1 September 2011
Author:catrope
Status:reverted (Comments)
Tags:
Comment:
Fix indentation in r95396
Modified paths:
  • /trunk/phase3/includes/Title.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Title.php
@@ -47,6 +47,7 @@
4848 */
4949 const GAID_FOR_UPDATE = 1;
5050
 51+
5152 /**
5253 * @name Private member variables
5354 * Please use the accessor functions instead.
@@ -758,7 +759,7 @@
759760
760761 /**
761762 * Return the prefixed title with spaces _without_ the interwiki prefix
762 - *
 763+ *
763764 * @return \type{\string} the title, prefixed by the namespace but not by the interwiki prefix, with spaces
764765 */
765766 public function getSemiPrefixedText() {
@@ -767,7 +768,7 @@
768769 $s = str_replace( '_', ' ', $s );
769770 $this->mSemiPrefixedText = $s;
770771 }
771 - return $this->mSemiPrefixedText;
 772+ return $this->mSemiPrefixedText;
772773 }
773774
774775 /**
@@ -998,7 +999,7 @@
9991000 public function escapeFullURL( $query = '' ) {
10001001 return htmlspecialchars( $this->getFullURL( $query ) );
10011002 }
1002 -
 1003+
10031004 /**
10041005 * HTML-escaped version of getCanonicalURL()
10051006 */
@@ -1010,7 +1011,7 @@
10111012 * Get the URL form for an internal link.
10121013 * - Used in various Squid-related code, in case we have a different
10131014 * internal hostname for the server from the exposed one.
1014 - *
 1015+ *
10151016 * This uses $wgInternalServer to qualify the path, or $wgServer
10161017 * if $wgInternalServer is not set. If the server variable used is
10171018 * protocol-relative, the URL will be expanded to http://
@@ -1035,9 +1036,9 @@
10361037 * Get the URL for a canonical link, for use in things like IRC and
10371038 * e-mail notifications. Uses $wgCanonicalServer and the
10381039 * GetCanonicalURL hook.
1039 - *
 1040+ *
10401041 * NOTE: Unlike getInternalURL(), the canonical URL includes the fragment
1041 - *
 1042+ *
10421043 * @param $query string An optional query string
10431044 * @param $variant string Language variant of URL (for sr, zh, ...)
10441045 * @return string The URL
@@ -3379,15 +3380,15 @@
33803381 array( 'rc_timestamp' => $rcts, 'rc_namespace' => $newns, 'rc_title' => $newdbk, 'rc_new' => 1 ),
33813382 __METHOD__
33823383 );
3383 -
 3384+
33843385 if ( $wgEnableInterwikiTemplatesTracking && $wgGlobalDatabase ) {
33853386 $dbw2 = wfGetDB( DB_MASTER, array(), $wgGlobalDatabase );
33863387 $dbw2->delete( 'globaltemplatelinks',
33873388 array( 'gtl_from_wiki' => wfGetID(),
33883389 'gtl_from_page' => $newid ),
33893390 __METHOD__ );
 3391+ }
33903392 }
3391 - }
33923393
33933394 # Save a null revision in the page's history notifying of the move
33943395 $nullRevision = Revision::newNullRevision( $dbw, $oldid, $comment, true );
@@ -3860,18 +3861,6 @@
38613862 }
38623863
38633864 /**
3864 - * Check if this title is a subpage of another title
3865 - *
3866 - * @param $title Title
3867 - * @return Bool
3868 - */
3869 - public function isSubpageOf( Title $title ) {
3870 - return $this->getInterwiki() === $title->getInterwiki()
3871 - && $this->getNamespace() == $title->getNamespace()
3872 - && strpos( $this->getDBkey(), $title->getDBkey() . '/' ) === 0;
3873 - }
3874 -
3875 - /**
38763865 * Callback for usort() to do title sorts by (namespace, title)
38773866 *
38783867 * @param $a Title

Follow-up revisions

RevisionCommit summaryAuthorDate
r95949Followup r95947, undo accidental revert of r95946.dantman08:34, 1 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95396Merge the iwtransclusion branch back into trunk...reedy13:03, 24 August 2011

Comments

#Comment by Nikerabbit (talk | contribs)   08:29, 1 September 2011

And also removed a method?

Status & tagging log