r95936 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95935‎ | r95936 | r95937 >
Date:05:24, 1 September 2011
Author:laner
Status:deferred (Comments)
Tags:
Comment:
Of course, doesn't work in static functions :). Follow up to r95934
Modified paths:
  • /trunk/extensions/OpenStackManager/OpenStackNovaUser.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OpenStackManager/OpenStackNovaUser.php
@@ -489,10 +489,9 @@
490490 * @return bool
491491 */
492492 static function LDAPSetNovaInfo( $auth ) {
493 - $this->userInfo = $auth->userInfo;
494 - if ( !$this->exists() ) {
495 - if ( !in_array( 'novauser', $this->userInfo[0]['objectclass'] ) ) {
496 - $values['objectclass'] = $this->userInfo[0]['objectclass'];
 493+ if ( !isset( $auth->userInfo[0]['accesskey'] ) or !isset( $auth->userInfo[0]['secretkey'] ) ) {
 494+ if ( !in_array( 'novauser', $auth->userInfo[0]['objectclass'] ) ) {
 495+ $values['objectclass'] = $auth->userInfo[0]['objectclass'];
497496 $values['objectclass'][] = 'novauser';
498497 }
499498 $values['accesskey'] = OpenStackNovaUser::uuid4();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r95934If a user is missing nova credentials upon login, add themlaner05:11, 1 September 2011

Comments

#Comment by Nikerabbit (talk | contribs)   07:21, 1 September 2011

And variables don't work with -m :)

#Comment by Ryan lane (talk | contribs)   17:46, 1 September 2011
D
#Comment by Ryan lane (talk | contribs)   17:46, 1 September 2011

or: :D

Status & tagging log