r95830 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r95829‎ | r95830 | r95831 >
Date:04:19, 31 August 2011
Author:dantman
Status:reverted (Comments)
Tags:
Comment:
Give Vector a lighter external/interwiki color since monobook->vector changed the basic internal link color lighter making internal and interwiki links almost indistinguishable.
Modified paths:
  • /trunk/phase3/skins/vector/screen.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/vector/screen.css
——@@ -1102,7 +1102,7 @@
11031103 /* Interwiki Styling */
11041104 div#content a.extiw,
11051105 div#content a.extiw:active {
1106 - color: #36b;
 1106+ color: #59e;
11071107 /* Don't show icons for interwiki links */
11081108 background: none;
11091109 padding: 0;
——@@ -1116,7 +1116,7 @@
11171117
11181118 /* External links */
11191119 div#content a.external {
1120 - color: #36b;
 1120+ color: #59e;
11211121 }
11221122 div#content a.external:visited {
11231123 color: #636; /* bug 3112 */

Sign-offs

UserFlagDate
Nikerabbitinspected14:52, 31 August 2011
Nikerabbittested14:52, 31 August 2011

Follow-up revisions

RevisionCommit summaryAuthorDate
r95950Revert r95830's change to external and interwiki link colors.dantman09:10, 1 September 2011

Comments

#Comment by Krinkle (talk | contribs)   23:24, 31 August 2011

This bright is too unreadable imho. Please revert.

#Comment by Krinkle (talk | contribs)   23:41, 31 August 2011

bug 3112 improved the difference between a normal, visited and active link a lot. I think those colors are good now.

The difference between a normal internal, interwiki or external link is still pretty narrow:

#Comment by Dantman (talk | contribs)   23:44, 31 August 2011

Externals were changed since it was the same color as interwikis. I changed these because vector's new link color is far closer to the interwiki color. Should I revert externals or both?

#Comment by Krinkle (talk | contribs)   23:45, 31 August 2011

Both. I see and agree completely that this is an issue, but this is simply unacceptable from a design perspective. Open a bug :)

Status & tagging log