r95813 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95812‎ | r95813 | r95814 >
Date:20:55, 30 August 2011
Author:demon
Status:resolved
Tags:
Comment:
Fixes for r94158: newlines and minor debugging typo (more silly fixmes)
Modified paths:
  • /trunk/phase3/includes/profiler/Profiler.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/profiler/Profiler.php
@@ -67,7 +67,7 @@
6868 if( is_array( $wgProfiler ) ) {
6969 if( !isset( $wgProfiler['class'] ) ) {
7070 wfDebug( __METHOD__ . " called without \$wgProfiler['class']"
71 - . ' set, falling back to ProfilerStub for safety' );
 71+ . " set, falling back to ProfilerStub for safety" );
7272 $class = 'ProfilerStub';
7373 } else {
7474 $class = $wgProfiler['class'];
@@ -76,8 +76,8 @@
7777 } elseif( $wgProfiler instanceof Profiler ) {
7878 self::$__instance = $wgProfiler; // back-compat
7979 } else {
80 - wfDebug( __METHOD__ . ' called without bogus $wgProfiler setting,'
81 - . ' falling back to ProfilerStub for safety' );
 80+ wfDebug( __METHOD__ . ' called with bogus $wgProfiler setting,'
 81+ . " falling back to ProfilerStub for safety\n" );
8282 self::$__instance = new ProfilerStub( $wgProfiler );
8383 }
8484 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r95814Another stupid newline, forgot to press savedemon20:55, 30 August 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94158Various profiler tweaks:...demon15:35, 10 August 2011

Status & tagging log