r95812 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95811‎ | r95812 | r95813 >
Date:20:53, 30 August 2011
Author:demon
Status:ok
Tags:
Comment:
Prefix extensions with $IP. Followup r94107 (grumble grumble about people fixmeing rather than doing the 4 character fix themselves...)
Modified paths:
  • /trunk/phase3/includes/installer/LocalSettingsGenerator.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/LocalSettingsGenerator.php
@@ -129,7 +129,7 @@
130130
131131 foreach( $this->extensions as $extName ) {
132132 $encExtName = self::escapePhpString( $extName );
133 - $localSettings .= "require_once( \"extensions/$encExtName/$encExtName.php\" );\n";
 133+ $localSettings .= "require_once( \"\$IP/extensions/$encExtName/$encExtName.php\" );\n";
134134 }
135135 }
136136

Follow-up revisions

RevisionCommit summaryAuthorDate
r96088MFT to REL1_18...hashar10:53, 2 September 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94107(bug 30264) MediaWiki installer uses require, de facto is require_oncedemon13:59, 9 August 2011

Status & tagging log