r95762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r95761‎ | r95762 | r95763 >
Date:12:17, 30 August 2011
Author:nikerabbit
Status:resolved (Comments)
Tags:
Comment:
This hack is not needed anymore with Html::element
Modified paths:
  • /trunk/extensions/Translate/TranslateTasks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslateTasks.php
@@ -357,9 +357,7 @@
358358 $data = $writer->webExport( $this->collection );
359359 }
360360
361 - return Xml::openElement( 'textarea', array( 'id' => 'wpTextbox1', 'rows' => '50' ) ) .
362 - $data .
363 - "</textarea>";
 361+ return Html::element( 'textarea', array( 'id' => 'wpTextbox1', 'rows' => '50' ), $text );
364362 }
365363 }
366364

Follow-up revisions

RevisionCommit summaryAuthorDate
r95767Follow-up r95762: $text was undefined, use $data.siebrand12:29, 30 August 2011

Comments

#Comment by Krinkle (talk | contribs)   12:23, 30 August 2011

$text is undefined.

#Comment by Nikerabbit (talk | contribs)   13:04, 30 August 2011

Good spot. This part of the code isn't currently in use, so I didn't actually test it.

Status & tagging log